Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS Headers & Update HTTP Status Codes #893

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Conversation

arun-koshy
Copy link
Contributor

Cross-Origin Resource Sharing (CORS) is an HTTP-header based mechanism that allows a server to indicate any origins (domain, scheme, or port) other than its own from which a browser should permit loading resources. CORS also relies on a mechanism by which browsers make a "preflight" request to the server hosting the cross-origin resource, in order to check that the server will permit the actual request. In that preflight, the browser sends headers that indicate the HTTP method and headers that will be used in the actual request.

Because the Dropshot framework cannot currently handle CORS preflight requests we will also require a CORS proxy that sits on top of the rest server to handle the preflight request (OPTIONS method) and then sends the actual request to the rest server.

sui/src/rest_server.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arun-koshy arun-koshy merged commit 794ece9 into main Mar 18, 2022
@arun-koshy arun-koshy deleted the arun/cors-headers branch March 18, 2022 17:45
mwtian pushed a commit that referenced this pull request Sep 12, 2022
Bumps [roaring](https://github.com/RoaringBitmap/roaring-rs) from 0.9.0 to 0.10.0.
- [Release notes](https://github.com/RoaringBitmap/roaring-rs/releases)
- [Commits](RoaringBitmap/roaring-rs@v0.9.0...v0.10.0)

---
updated-dependencies:
- dependency-name: roaring
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mwtian pushed a commit to mwtian/sui that referenced this pull request Sep 29, 2022
Bumps [roaring](https://github.com/RoaringBitmap/roaring-rs) from 0.9.0 to 0.10.0.
- [Release notes](https://github.com/RoaringBitmap/roaring-rs/releases)
- [Commits](RoaringBitmap/roaring-rs@v0.9.0...v0.10.0)

---
updated-dependencies:
- dependency-name: roaring
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants