Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding commit hash to simtest message in slack #8799

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Adding commit hash to simtest message in slack #8799

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e20bcdc
Adding more info to simtest message in slack
ebmifa Mar 2, 2023
3bc0f7d
Adding more logic
ebmifa Mar 2, 2023
2d92b61
syntax fixes
ebmifa Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
syntax fixes
  • Loading branch information
@ebmifa
ebmifa committed Mar 2, 2023
commit 2d92b61b6ab8b10515e95673d35025950823902b
17 changes: 8 additions & 9 deletions .github/workflows/simulator-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ jobs:
- name: Install nexttest
uses: taiki-e/install-action@nextest

# - name: Build simtest
# run: |
# export RUST_LOG=off
# ./scripts/simtest/cargo-simtest simtest build
- name: Build simtest
run: |
export RUST_LOG=off
./scripts/simtest/cargo-simtest simtest build

# - name: Run simtest
# run: |
# export RUST_LOG=off
# ./scripts/simtest/simtest-run.sh
- name: Run simtest
run: |
export RUST_LOG=off
./scripts/simtest/simtest-run.sh

notify:
name: Notify
Expand All @@ -69,7 +69,6 @@ jobs:
export sui_sha=$(git rev-parse HEAD)
echo "sui_sha=${sui_sha}" >> $GITHUB_ENV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does casing matter here?

Suggested change
echo "sui_sha=${sui_sha}" >> $GITHUB_ENV
echo "SUI_SHA=${sui_sha}" >> $GITHUB_ENV

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, it does. Line 76 refers to it.



- name: Post to slack
uses: slackapi/slack-github-action@936158bbe252e9a6062e793ea4609642c966e302 # pin@v1.21.0
env:
Expand Down