[move] Disable debug printing on nodes #8795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
bmwill
force-pushed
the
amnn/no-move-debug
branch
from
4add03e to
5f14fcf
Compare
bmwill
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Ok I've done the necessary fixes with hakari to eliminate the testing feature from being turned on by workspace-hack packages. One thing to note is that if sui-node is built together with another target that does enabling the testing feature, then it'll get turned on in the final build but at least now it wont be enabled if its built by itself.
Move cost-calibration and unit testing code to `sui-move`.
amnn
added a commit
that referenced
this pull request
Apr 8, 2023
Despite trying to disable printing using feature flags in #8795, it came back because of the additive nature of `feature`s. This time, disable debug printing on validators and full nodes for good, by controlling their inclusion using a flag passed in during native function creation, that controls whether to link against a silent version of the debug print functions or not. Unit tests, and other CLI usages of the VM typically link against the unsilenced native functions, and the version used by validators is silenced. Test Plan: Run all existing tests: ``` $ cargo simtest $ env SUI_SKIP_SIMTESTS=1 cargo nextest run ``` Create a test move package with the following content: ``` module test::test { struct ImALittleTeapot has copy, drop, store {} public entry fun print() { std::debug::print(&ImALittleTeapot {}); } #[test] fun test_printing() { print(); } } ``` And confirm that the following does print debug output ``` sui$ cargo build --bin sui --release sui$ cargo build --bin sui-node --release sui$ ./target/release/sui move test -p $PKG ``` While publishing to a local network and repeatedly calling `print` does not pollute the validator or fullnode logs.
amnn
added a commit
that referenced
this pull request
Apr 8, 2023
## Description Despite trying to disable printing using feature flags in #8795, it came back because of the additive nature of `feature`s. This time, disable debug printing on validators and full nodes for good, by controlling their inclusion using a flag passed in during native function creation, that controls whether to link against a silent version of the debug print functions or not. Unit tests, and other CLI usages of the VM typically link against the unsilenced native functions, and the version used by validators is silenced. ## Test Plan Run all existing tests: ``` $ cargo simtest $ env SUI_SKIP_SIMTESTS=1 cargo nextest run ``` Create a test move package with the following content: ``` module test::test { struct ImALittleTeapot has copy, drop, store {} public entry fun print() { std::debug::print(&ImALittleTeapot {}); } #[test] fun test_printing() { print(); } } ``` And confirm that the following does print debug output ``` sui$ cargo build --bin sui --release sui$ cargo build --bin sui-node --release sui$ ./target/release/sui move test -p $PKG ``` While publishing to a local network and repeatedly calling `print` does not pollute the validator or fullnode logs.
sblackshear
pushed a commit
to sblackshear/sui
that referenced
this pull request
Apr 10, 2023
## Description Despite trying to disable printing using feature flags in MystenLabs#8795, it came back because of the additive nature of `feature`s. This time, disable debug printing on validators and full nodes for good, by controlling their inclusion using a flag passed in during native function creation, that controls whether to link against a silent version of the debug print functions or not. Unit tests, and other CLI usages of the VM typically link against the unsilenced native functions, and the version used by validators is silenced. ## Test Plan Run all existing tests: ``` $ cargo simtest $ env SUI_SKIP_SIMTESTS=1 cargo nextest run ``` Create a test move package with the following content: ``` module test::test { struct ImALittleTeapot has copy, drop, store {} public entry fun print() { std::debug::print(&ImALittleTeapot {}); } #[test] fun test_printing() { print(); } } ``` And confirm that the following does print debug output ``` sui$ cargo build --bin sui --release sui$ cargo build --bin sui-node --release sui$ ./target/release/sui move test -p $PKG ``` While publishing to a local network and repeatedly calling `print` does not pollute the validator or fullnode logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable outputting
debug::printto stderr on full nodes and validators, to prevent user code from spamming our logs, while still enabling output for calls via CLI (e.g. tosui move test). Removes a dependency fromsui-frameworktomove-unit-testto make this work, by:cost_calibmodule tosui-move.Test Plan
With the following Move package:
Build
suiCLI andsui-nodeseparately so that Cargo does not unify features, and start-up the validators embedded in the CLI, and a separate fullnode (in separate terminal sessions):Running the tests will print the debug output, and publishing and running transactions will produce debug output in the embedded validator, but not the dedicated fullnode: