[9/x][programmable transactions] Added errors #8767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
tnowacki
commented
Mar 1, 2023
| /// Errors if out of bounds, if the argument is borrowed, if it is unavailable (already taken), | ||
| /// or if it is an object that cannot be taken by value (shared or immutable) | ||
| pub fn take_arg<V: TryFromValue>( | ||
| pub fn by_value_arg<V: TryFromValue>( |
There was a problem hiding this comment.
Thanks for the suggestion @amnn!
6 tasks
amnn
approved these changes
Mar 2, 2023
| @@ -2357,6 +2376,22 @@ pub struct InvalidSharedByValue { | |||
| pub object: ObjectID, | |||
| } | |||
|
|
|||
| #[derive(Eq, PartialEq, Clone, Debug, Serialize, Deserialize, Hash)] | |||
| pub enum CommandArgumentError { | |||
There was a problem hiding this comment.
Would benefit from some docs:
- An overall doc comment reminding folks that these come from programmable transaction commands.
- A short description of how these errors come about (especially for the
Invalid*errors -- what makes those things invalid?)
There was a problem hiding this comment.
(Or alternatively, a pointer in the outer doc comment to say that the Display implementation has this information
-- is there any chance we could use thiserror for this to bring these two things together?).
There was a problem hiding this comment.
Oooo fancy, will do
bmwill
approved these changes
Mar 2, 2023
- Replaced panics with execution errors
|
Removed the error for unused input, so should fix #8776 |
tnowacki
added a commit
that referenced
this pull request
Mar 3, 2023
## Description Adds a programmable transaction builder. APIs are there mostly for migration. Builds on #8767 ## Test Plan Not yet in use --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced panics with execution errors
Test Plan
👀
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes