Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet-ext: clear permissions and active account #8662

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

pchrysochoidis
Copy link
Contributor

@pchrysochoidis pchrysochoidis commented Feb 26, 2023

Description

  • permissions have the connected account using the previous address size
  • to avoid any errors clear them and let users reconnect to dapps
  • active account wont create any issues if it remains in previous format but we can clear it to avoid any confusion

Test Plan

manual testing

  • use a previous version connect to a dapp, update the wallet and check storage
  • when updating to a newer version from one that contains this change, make sure it does't remove permissions/active address

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Clears the existing permissions in the wallet extension (disconnects all connected sites) to migrate to new account address format.

@vercel
Copy link

vercel bot commented Feb 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:37PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:37PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:37PM (UTC)

@joyqvq joyqvq force-pushed the bench-address32 branch 5 times, most recently from abf8cc5 to 5d3f521 Compare February 28, 2023 19:59
Base automatically changed from bench-address32 to main February 28, 2023 20:28
* permissions have the connected account using the previous address size
* to avoid any errors clear them and let users reconnect to dapps
* active account wont create any issues if it remains in previous format but we can clear it to avoid any confusion
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-address-size-change-clear-storage branch from e2e6545 to 5e58994 Compare March 2, 2023 13:37
@pchrysochoidis pchrysochoidis merged commit 69652e0 into main Mar 2, 2023
@pchrysochoidis pchrysochoidis deleted the pc-wallet-address-size-change-clear-storage branch March 2, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants