Improve validator shutdown test #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
amnn
approved these changes
Feb 24, 2023
Comment on lines
108
to
110
| assert!(!v.is_running()); | ||
| } else { | ||
| assert!(v.is_running()); |
There was a problem hiding this comment.
nit, can you add a message to the asserts to identify each validator, in case it fails, to help track down what happened?
crates/sui-swarm/src/memory/node.rs
Outdated
Comment on lines
76
to
77
| .map(|c| c.is_alive()) | ||
| .unwrap_or(false) |
There was a problem hiding this comment.
nit: map_or_else?
Suggested change
| .map(|c| c.is_alive()) | |
| .unwrap_or(false) | |
| .map_or(false, |c| c.is_alive()) |
mystenmark
force-pushed
the
mlogan-test-shutdown
branch
from
f2fab47 to
4816929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of expecting a simple panic, we check that a validator that no longer supports the current protocol version shuts itself down.