wallet-ext: multiple accounts in active connections view #8436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pchrysochoidis
changed the base branch from
main
to
pc-wallet-ext-apps-283-app-connect-select-accounts
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-284-active-accounts
branch
from
795f887 to
321343d
Compare
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-284-active-accounts
branch
from
321343d to
ede4922
Compare
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-284-active-accounts
branch
from
ede4922 to
75a2bc0
Compare
pchrysochoidis
requested review from
Jibz1,
Jordan-Mysten,
mamos-mysten and
mystie711
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-283-app-connect-select-accounts
branch
from
41a4c50 to
42c80dc
Compare
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-284-active-accounts
branch
from
75a2bc0 to
84e0389
Compare
|
Looking good overall. Some UI polish items below. Double check the check-unselected color & the row item color, Update text to "Minting failed. Try again in a bit." Update resting arrow color, Could we move the toast during fade out so it does not look like it overlaps the bottom footer? Shorten the move distance. And yes, please apply this universally to all toasts in the component we use! |
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-284-active-accounts
branch
from
0737ac4 to
1743a5f
Compare
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-283-app-connect-select-accounts
branch
from
074e62b to
9b86bc8
Compare
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-284-active-accounts
branch
from
1743a5f to
8097910
Compare
Base automatically changed from
pc-wallet-ext-apps-283-app-connect-select-accounts
to
main
February 24, 2023 13:05
* move the creation of the explorer link out of the ExplorerLink component
* added DAppInfoCard a box that shows the dapp icon name and link * added DAppPermissionsList that shows a list of permissions * updated SummaryCard to fix overflow and borders for footer and add a divider option * updated WalletListSelect to add disconnect mode, disabled state and allow filtering visible accounts
* allow disconnecting specific account from a dapp * some refactoring for SuiApps to * connected apps to use also the data from the WalletDapps list * simplify Props * fix stylings and use new components like Link and Button
* use suiDark link color in DAppInfoCard
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-284-active-accounts
branch
from
8097910 to
ae023d8
Compare
Jibz1
reviewed
Feb 24, 2023
| <div className={st.desc}> | ||
| <div className={st.title}>Builders in sui ecosystem</div> | ||
| {ecosystemApps?.length ? ( | ||
| <> | ||
| Apps here are actively curated but do not indicate any |
There was a problem hiding this comment.
not a blocker we could use Text component here
Jibz1
reviewed
Feb 24, 2023
| href={accountOnExplorerHref!} | ||
| text="View account on Sui Explorer" | ||
| onClick={() => { | ||
| trackEvent('ViewExplorerAccount'); |
There was a problem hiding this comment.
no need for the bracket before and after trackEvent
Jibz1
reviewed
Feb 24, 2023
| title={name} | ||
| className={st.ecosystemApp} | ||
| showIcon={false} | ||
| onClick={onClickAppLink} | ||
| onClick={() => { | ||
| trackEvent('AppOpen', { |
Jibz1
approved these changes
Feb 24, 2023
|
@Jibz1 about the Text component, we should revisit the components used here anyway to remove scss modules use new UI components etc. Now I just tried to touch as less as possible in interest of time. Will leave this and the function props to be addressed at that time. About the issue you mean the one we discussed offline right (not something else)? - When we connect to a site and we have the wallet in the connected view on another tab, the list of connected apps doesn't update (jira issue) . This is an existing behaviour and this PR didn't break it so I think it should be addressed in another PR. |
pchrysochoidis
added a commit
that referenced
this pull request
Mar 1, 2023
* useExplorerLink hook
* move the creation of the explorer link out of the ExplorerLink
component
* components to be used in connected dapps view
* added DAppInfoCard a box that shows the dapp icon name and link
* added DAppPermissionsList that shows a list of permissions
* updated SummaryCard to fix overflow and borders for footer and add a
divider option
* updated WalletListSelect to add disconnect mode, disabled state and
allow filtering visible accounts
* add functionality to disconnect only specific accounts
* support multi accounts in connected apps view
* allow disconnecting specific account from a dapp
* some refactoring for SuiApps to
* connected apps to use also the data from the WalletDapps list
* simplify Props
* fix stylings and use new components like Link and Button
* mint demo nft toasts and using mutation
Playground/WalletApps listing page styling changes
https://user-images.githubusercontent.com/10210143/220197176-e68aff9e-515b-4633-a82d-275c721cd5db.mov
Multi-accounts in Disconnect app view
https://user-images.githubusercontent.com/10210143/220197372-c982fc9e-ba83-4820-896c-c08e902a203e.mov
https://user-images.githubusercontent.com/10210143/220197417-730f9b3b-2fd8-47c7-a95d-6f5aa45856c4.mov
https://user-images.githubusercontent.com/10210143/220197467-b2a682d2-23ed-42dc-a484-66e9c69ed3b6.mov
closes APPS-284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playground/WalletApps listing page styling changes
Screen.Recording.2023-02-20.at.20.50.58.mov
Multi-accounts in Disconnect app view
Screen.Recording.2023-02-20.at.20.51.59.mov
Screen.Recording.2023-02-20.at.20.53.47.mov
Screen.Recording.2023-02-20.at.20.54.18.mov
closes APPS-284