Update activities to show txn originating from current address #8396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jibz1
force-pushed
the
gj-wallet-txn-update
branch
from
4ecdd50 to
75271fb
Compare
Jibz1
force-pushed
the
gj-wallet-txn-update
branch
from
75271fb to
6d2ec94
Compare
Jibz1
force-pushed
the
gj-wallet-txn-update
branch
from
6d2ec94 to
94a4516
Compare
6 tasks
williamrobertson13
approved these changes
Mar 1, 2023
| @@ -37,7 +37,7 @@ export function CoinActivitiesCard({ coinType }: { coinType: string }) { | |||
| <div className="p-2"> | |||
| <Alert mode="warning"> | |||
| <div className="font-semibold"> | |||
| {error?.message || 'Something went wrong'} | |||
| {(error as Error).message} | |||
There was a problem hiding this comment.
no need to fix this in this PR, but I think it would be better to type the Error field in our useQuery call inside useGetTransactionsByAddress so we don't have to manually cast error
| }); | ||
| return rpc.getTransactionWithEffectsBatch(txnIdDs.data); | ||
| // combine from and to transactions | ||
| const [txnIdDs, fromTxnIds] = await Promise.all([ |
There was a problem hiding this comment.
Suggested change
| const [txnIdDs, fromTxnIds] = await Promise.all([ | |
| const [txnIds, fromTxnIds] = await Promise.all([ |
typo I think?
Jibz1
force-pushed
the
gj-wallet-txn-update
branch
from
bf9cdf3 to
66e9a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTransactionsto use bothToAddressandFromAddress