Shutdown server runtime before program exit #8313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
sadhansood
force-pushed
the
sadhan/graceful
branch
from
76ba39e to
6d663af
Compare
mwtian
approved these changes
Feb 15, 2023
| @@ -41,13 +42,19 @@ pub struct ProxyGasAndCoin { | |||
| pub pay_coin_type_tag: TypeTag, | |||
| } | |||
|
|
|||
| pub struct BenchmarkSetup { | |||
| pub server_handle: JoinHandle<()>, | |||
| pub sender: oneshot::Sender<()>, | |||
There was a problem hiding this comment.
Can we give this a more descriptive name, e.g. shutdown_notifier?
|
Great! |
sadhansood
force-pushed
the
sadhan/graceful
branch
from
6d663af to
20f4084
Compare
sadhansood
force-pushed
the
sadhan/graceful
branch
from
20f4084 to
6b23050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't ever terminate the server runtime in benchmark when we exit the program. This causes RocksDB running in the server runtime to try to access global state which is cleaned up during exit. This PR terminates the server runtime with a oneshot channel and then exit.
Before this fix, I can reproduce the error in almost every run on my linux computer. After this PR, I did not run into any errors even after 10+ runs.