Bump fastcrypto version #8228
Merged
Bump fastcrypto version #8228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
jonas-lj
requested review from
joyqvq,
patrickkuo,
kchalkias and
benr-ml
as code owners
benr-ml
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps Sui to the most recent version of fastcrypto. There's been a few changes in the traits in fastcrypto, namely that
signature::Signerandsignature::Signatureare no longer used. In fastcrypto, these were replaced with new internal traitsSignerandToFromBytesrespectively.The new
Signertrait does not have atry_signfunction like the previous one, but the only place this ever returns an error isSuiInnerSiganture::newif a serialised signature does not have the correct size. This should never happen, so we can safely remove this error.Besides the removed error, this does not introduce any functional changes.