Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frenemies] UI tweaks #8096

Merged
merged 2 commits into from
Feb 6, 2023
Merged

[frenemies] UI tweaks #8096

merged 2 commits into from
Feb 6, 2023

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Feb 4, 2023

  • Change error name to: “No SUI coins found in your wallet. You need SUI to play the Frenemies game”
  • Fix high score no data when leaderboard is empty
  • Show -- before participation history is loaded
  • “Score” -> “Points scored”
  • Update score (from total and round score to just round score)
  • Add a logo to the scorecard
  • Scroll into validator when current assignment clicked
  • If there's assignment for the previous epoch but new round is not played - show "pending" or "--" instead of "skipped"
  • Notification banners
  • Better error notifications

@damirka damirka requested a review from Jordan-Mysten February 4, 2023 13:38
@vercel
Copy link

vercel bot commented Feb 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
frenemies ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 11:27PM (UTC)
3 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:27PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:27PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:27PM (UTC)

@vercel vercel bot temporarily deployed to Preview – frenemies February 6, 2023 21:03 Inactive
@vercel vercel bot temporarily deployed to Preview – frenemies February 6, 2023 23:27 Inactive
@Jordan-Mysten Jordan-Mysten merged commit e79ebc5 into main Feb 6, 2023
@Jordan-Mysten Jordan-Mysten deleted the ds/frenemies-ui-fixes branch February 6, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jordan-Mysten Jordan-Mysten Jordan-Mysten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damirka @Jordan-Mysten