[4/x][signing] Don't sign mutable access to the Clock #8092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnn
requested review from
tharbert,
randall-Mysten and
ronny-mysten
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
andll
approved these changes
Feb 6, 2023
amnn
force-pushed
the
clock-txn-input
branch
2 times, most recently
from
fba7952 to
ca6acfb
Compare
tnowacki
reviewed
Feb 13, 2023
| @@ -343,6 +344,15 @@ fn check_one_object( | |||
| } | |||
| }; | |||
| } | |||
| InputObjectKind::SharedMoveObject { | |||
There was a problem hiding this comment.
Should we do anything similar for the system object? Is it only mutated in system transactions?
There was a problem hiding this comment.
No, sadly not -- (at least not currently) -- delegation requests will touch it, IIRC.
User transactions that request mutable access (requiring a write lock) to the singleton `Clock` at address `0x6` will not be signed by honest validators. This prevents those transactions from (intentionally or otherwise) bottlenecking throughput on transactions that reference the `Clock` by taking an exclusive lock on it. Test Plan: New unit tests in `authority_tests`: ``` $ cargo nextest run -- test_invalid_mutable_clock_parameter $ cargo nextest run -- test_valid_immutable_clock_parameter ```
amnn
force-pushed
the
clock-txn-input
branch
from
ca6acfb to
42bb5df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User transactions that request mutable access (requiring a write lock) to the singleton
Clockat address0x6will not be signed by honest validators.This prevents those transactions from (intentionally or otherwise) bottlenecking throughput on transactions that reference the
Clockby taking an exclusive lock on it.Test Plan
New unit tests in
authority_tests:Stack