[Narwhal] Record number of parents and leader support in proposed headers #7730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
akichidis
reviewed
Jan 26, 2023
| pub headers_proposed: IntCounterVec, | ||
| // total number of parents in all proposed headers, for calculating average number of parents | ||
| // per header. | ||
| pub header_parents_total: IntCounter, |
There was a problem hiding this comment.
You could alternatively use a Histogram here that would give you better break down + you can always use it to calculate avg as well. I've found that particularly useful in similar cases.
There was a problem hiding this comment.
I thought about it but setting buckets is a bit problematic. But let me update this.
akichidis
reviewed
Jan 26, 2023
| @@ -228,6 +228,24 @@ impl Proposer { | |||
| ) | |||
| .await; | |||
|
|
|||
| let leader_support = if this_round % 2 == 0 { | |||
| "even_round" | |||
There was a problem hiding this comment.
Maybe you could also use two labels here, if this is the leader of the round it could be leader, otherwise even_round
akichidis
approved these changes
Jan 26, 2023
|
Let me update this. |
mwtian
added a commit
that referenced
this pull request
Jan 26, 2023
…ders (#7730) This could help with investigating differences between networks.
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
…ders (#7730) This could help with investigating differences between networks.
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
Addressing feedback from #7730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could help with investigating differences between networks.