Refactor dynamic fields test ts sdk #7715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
666lcz
suggested changes
Jan 27, 2023
| expect(dynamic_fields.nextCursor).not.toEqual(null); | ||
| return await toolbox.provider | ||
| .getDynamicFields(parent_objectID, null, 1) | ||
| .then(async function (dynamic_fields) { |
There was a problem hiding this comment.
Suggested change
| .then(async function (dynamic_fields) { | |
| .then(async function (dynamicFields) { |
The convention in TypeScript is to use camelCase for variable naming, could you fix it for all variables in this file?
| @@ -106,5 +106,5 @@ export async function publishPackage( | |||
| const publishEvent = getEvents(publishTxn).filter( | |||
| (e: any) => 'publish' in e | |||
| )[0]; | |||
| return publishEvent.publish.packageId.replace(/^0x(0+)/, '$1'); | |||
| return publishEvent.publish.packageId.replace(/^0x(0+)/, '0x'); | |||
There was a problem hiding this comment.
Thanks for fixing this! I made a typo here, should be replace(/(^0x)(0+)/, '0x'); instead of replace(/^0x(0+)/, '0x');. Your change here is clearer
Comment on lines
60
to
66
|
|
||
| return await toolbox.provider | ||
| .getDynamicFields(parent_objectID, dynamic_fields.nextCursor, null) | ||
| .then(function (dynamic_fields2) { | ||
| expect(dynamic_fields2.data.length).greaterThanOrEqual(0); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I actually don't think the refactoring of mixing await with callback makes sense. The bug seems to be in the backend rather than here
666lcz
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.