[wallet] - add connected network name to wallet logo #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
mamos-mysten
force-pushed
the
mamos--wallet-connected-network
branch
from
3cf9fd8 to
6b497cf
Compare
| className="text-hero mt-7.5" | ||
| txt={true} | ||
| /> | ||
| <Logo className="text-hero mt-7.5" /> |
There was a problem hiding this comment.
If we're re-doing this can we also just make it stop taking className as a prop?
| @@ -41,7 +43,7 @@ export default function PageMainLayout({ | |||
| })} | |||
| > | |||
| <Link to="/tokens" className={st.logoLink}> | |||
| <Logo className={st.logo} txt={true} /> | |||
| <Logo className={st.logo} networkName={networkName} /> | |||
There was a problem hiding this comment.
Same here, would love to work className out of it.
|
ship it. |
Jordan-Mysten
approved these changes
Jan 26, 2023
|
|
||
| type LogoProps = { | ||
| size?: 'normal' | 'big' | 'bigger' | 'huge'; | ||
| txt?: boolean; | ||
| networkName?: API_ENV; | ||
| className?: string; |
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
add connected network name below the sui logo went through a few different iterations with this... this version ended up being the simplest with the least amount of code changes. the other iterations included: - add a `public` folder and serve the SVGs as static assets. this breaks down with the blue color treatment on the landing page - import logos as SVG components. required adding an svg-loader to wallet I can revive those branches if we think either one is a better approach.  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
went through a few different iterations with this... this version ended up being the simplest with the least amount of code changes. the other iterations included:
publicfolder and serve the SVGs as static assets. this breaks down with the blue color treatment on the landing pageI can revive those branches if we think either one is a better approach.