Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate handle_transaction metrics #7644

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Consolidate handle_transaction metrics #7644

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cadfb5d
Consolidate handle_transaction metrics
mystenmark Jan 24, 2023
4a01076
Increase timeout for test, add logging for duration
mystenmark Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Consolidate handle_transaction metrics
  • Loading branch information
@mystenmark
mystenmark committed Jan 24, 2023
commit cadfb5d23d5684a79ee1b299f562cf521694aa26
26 changes: 5 additions & 21 deletions crates/sui-core/src/authority_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ pub struct ValidatorServiceMetrics {
pub tx_verification_latency: Histogram,
pub cert_verification_latency: Histogram,
pub consensus_latency: Histogram,
pub handle_transaction_consensus_latency: Histogram,
pub handle_transaction_non_consensus_latency: Histogram,
pub handle_transaction_latency: Histogram,
pub handle_certificate_consensus_latency: Histogram,
pub handle_certificate_non_consensus_latency: Histogram,

Expand Down Expand Up @@ -177,16 +176,9 @@ impl ValidatorServiceMetrics {
registry,
)
.unwrap(),
handle_transaction_consensus_latency: register_histogram_with_registry!(
"validator_service_handle_transaction_consensus_latency",
"Latency of handling a consensus transaction",
LATENCY_SEC_BUCKETS.to_vec(),
registry,
)
.unwrap(),
handle_transaction_non_consensus_latency: register_histogram_with_registry!(
"validator_service_handle_transaction_non_consensus_latency",
"Latency of handling a non-consensus transaction",
handle_transaction_latency: register_histogram_with_registry!(
"validator_service_handle_transaction_latency",
"Latency of handling a transaction",
LATENCY_SEC_BUCKETS.to_vec(),
registry,
)
Expand Down Expand Up @@ -252,15 +244,7 @@ impl ValidatorService {
) -> Result<tonic::Response<TransactionInfoResponse>, tonic::Status> {
let transaction = request.into_inner();

let is_consensus_tx = transaction.contains_shared_object();

let _metrics_guard = if is_consensus_tx {
metrics.handle_transaction_consensus_latency.start_timer()
} else {
metrics
.handle_transaction_non_consensus_latency
.start_timer()
};
let _metrics_guard = metrics.handle_transaction_latency.start_timer();
let tx_verif_metrics_guard = metrics.tx_verification_latency.start_timer();

let transaction = transaction.verify().tap_err(|_| {
Expand Down