Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/2][client] Remove --verify-dependencies #7633

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[2/2][client] Remove --verify-dependencies #7633

merged 1 commit into from
Jan 31, 2023

Conversation

amnn
Copy link
Member

@amnn amnn commented Jan 24, 2023

Remove the --verify-dependencies flag, which was deprecated in the
previous release (see #7632).

Breaking Changes

  • --verify-dependencies flag for sui client publish is no longer
    accepted, after being deprecated for a release.

Test Plan

$ cargo nextest run

Stack

@amnn amnn added cli Command line tools breaking change labels Jan 24, 2023
@amnn amnn self-assigned this Jan 24, 2023
@vercel
Copy link

vercel bot commented Jan 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:29PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:29PM (UTC)
frenemies ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:29PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:29PM (UTC)

@amnn amnn force-pushed the remove-verify-deps branch from ecfd879 to 4b51f08 Compare January 24, 2023 17:00
@amnn
[2/2][client] Remove --verify-dependencies
30eea03 
Remove the `--verify-dependencies` flag, which was deprecated in the
previous release (see MystenLabs#7632).

Breaking Changes:

- `--verify-dependencies` flag for `sui client publish` is no longer
  accepted, after being deprecated for a release.

Test Plan:

```
$ cargo nextest run
```
@amnn amnn force-pushed the remove-verify-deps branch from 4b51f08 to 30eea03 Compare January 31, 2023 15:28
@amnn amnn enabled auto-merge (squash) January 31, 2023 15:29
oxade
oxade approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@oxade oxade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amnn amnn merged commit faa880c into MystenLabs:main Jan 31, 2023
@amnn amnn deleted the remove-verify-deps branch January 31, 2023 16:11
williampsmith pushed a commit that referenced this pull request Feb 3, 2023
@amnn @williampsmith
[2/2][client] Remove --verify-dependencies (#7633)
52c0430 
Remove the `--verify-dependencies` flag, which was deprecated in the
previous release (see #7632).

## Breaking Changes

- `--verify-dependencies` flag for `sui client publish` is no longer
  accepted, after being deprecated for a release.

## Test Plan

```
$ cargo nextest run
```

## Stack

- #7632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxade oxade oxade approved these changes

@rvantonder rvantonder rvantonder approved these changes

@tnowacki tnowacki Awaiting requested review from tnowacki

@sblackshear sblackshear Awaiting requested review from sblackshear

Assignees

@amnn amnn

Labels
breaking change cli Command line tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amnn @rvantonder @oxade