Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet-ext: account selector in tokens view #7628

Merged
merged 2 commits into from
Feb 3, 2023
Merged

wallet-ext: account selector in tokens view #7628

merged 2 commits into from
Feb 3, 2023

Conversation

pchrysochoidis
Copy link
Contributor

@pchrysochoidis pchrysochoidis commented Jan 24, 2023 •
edited
Loading

  • under wallet-multi-accounts feature flag
  • replaces ... to … for ellipsis hook
  • adds address to query key hash for the useRecentTransactions to load transactions for the current active address
  • changes the way we clear objects from store and now we do it from home component until we move it to query

When only one account is available or wallet-multi-accounts is disabled

Screen.Recording.2023-02-01.at.18.28.25.mov

For multi-accounts

Screen.Recording.2023-02-01.at.18.30.33.mov
Screen.Recording.2023-02-01.at.18.31.08.mov

closes: APPS-296

@vercel
Copy link

vercel bot commented Jan 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
explorer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 11:46PM (UTC)
frenemies ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 11:46PM (UTC)
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 11:46PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
explorer-storybook ⬜️ Ignored (Inspect) Feb 2, 2023 at 11:46PM (UTC)

@vercel vercel bot temporarily deployed to Preview – frenemies January 24, 2023 11:23 Inactive
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-2 branch from b16eaaa to e33fddc Compare January 24, 2023 12:02
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-3 branch from 0180800 to f8690be Compare January 24, 2023 12:06
@vercel vercel bot temporarily deployed to Preview – frenemies January 24, 2023 12:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-adapter January 24, 2023 12:07 Inactive
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-2 branch 2 times, most recently from ab5d9ed to 3e8a8ab Compare January 30, 2023 22:24
Base automatically changed from pc-wallet-ext-apps-296-home-account-switch-2 to main January 31, 2023 13:03
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-3 branch 2 times, most recently from a40e74c to 6ecf422 Compare February 1, 2023 18:22
@vercel vercel bot temporarily deployed to Preview – frenemies February 1, 2023 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-adapter February 1, 2023 18:22 Inactive
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-3 branch from 6ecf422 to f1f2da4 Compare February 1, 2023 18:23
@vercel vercel bot temporarily deployed to Preview – wallet-adapter February 1, 2023 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – frenemies February 1, 2023 18:25 Inactive
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-3 branch from f1f2da4 to a285d18 Compare February 1, 2023 18:26
@vercel vercel bot temporarily deployed to Preview – wallet-adapter February 1, 2023 18:27 Inactive
@vercel vercel bot temporarily deployed to Preview – frenemies February 1, 2023 18:27 Inactive
@pchrysochoidis pchrysochoidis changed the title (wip) wallet-ext: account selector wallet-ext: account selector in tokens view Feb 1, 2023
@pchrysochoidis pchrysochoidis marked this pull request as ready for review February 1, 2023 18:42
@mystie711
Copy link
Collaborator

@pchrysochoidis realized one small delta in Figma that i have now updated.
For single wallet interaction, on-hover over the pill, could we also have the icon be colorized?
image

mystie711
mystie711 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@mystie711 mystie711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.

@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-3 branch from a285d18 to d2cde6f Compare February 1, 2023 22:44
@vercel vercel bot temporarily deployed to Preview – wallet-adapter February 1, 2023 22:44 Inactive
@vercel vercel bot temporarily deployed to Preview – frenemies February 1, 2023 22:44 Inactive
@pchrysochoidis
Copy link
Contributor Author

@pchrysochoidis realized one small delta in Figma that i have now updated. For single wallet interaction, on-hover over the pill, could we also have the icon be colorized? image

Updated it

Screen.Recording.2023-02-01.at.22.52.06.mov
Screen.Recording.2023-02-01.at.22.52.55.mov

@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-3 branch from d2cde6f to 27105f8 Compare February 2, 2023 12:42
@vercel vercel bot temporarily deployed to Preview – frenemies February 2, 2023 12:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-adapter February 2, 2023 12:42 Inactive
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-3 branch from 27105f8 to f486454 Compare February 2, 2023 20:24
@vercel vercel bot temporarily deployed to Preview – wallet-adapter February 2, 2023 20:24 Inactive
@vercel vercel bot temporarily deployed to Preview – frenemies February 2, 2023 20:24 Inactive
@pchrysochoidis
wallet-ext: account selector in tokens view
5574835 
* under `wallet-multi-accounts` feature flag
@pchrysochoidis
wallet-ext: pr comments
d04af8d 
* hover state for copy address icon
* 200ms duration for closing account selector popover
@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ext-apps-296-home-account-switch-3 branch from f486454 to d04af8d Compare February 2, 2023 23:45
@vercel vercel bot temporarily deployed to Preview – wallet-adapter February 2, 2023 23:45 Inactive
@vercel vercel bot temporarily deployed to Preview – frenemies February 2, 2023 23:45 Inactive
@pchrysochoidis
Copy link
Contributor Author

Thanks @mamos-mysten, I updated the animation to 200ms and added the hover state

Screen.Recording.2023-02-02.at.23.42.50.mov

mamos-mysten
mamos-mysten approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@mamos-mysten mamos-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@pchrysochoidis pchrysochoidis merged commit bbbdbec into main Feb 3, 2023
@pchrysochoidis pchrysochoidis deleted the pc-wallet-ext-apps-296-home-account-switch-3 branch February 3, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamos-mysten mamos-mysten mamos-mysten approved these changes

@mystie711 mystie711 mystie711 approved these changes

@Jibz1 Jibz1 Awaiting requested review from Jibz1

@Jordan-Mysten Jordan-Mysten Awaiting requested review from Jordan-Mysten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchrysochoidis @mystie711 @mamos-mysten