[TypeScript SDK] Add methods for the CoinRead endpoints #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
666lcz
approved these changes
Jan 20, 2023
| } | ||
| } | ||
|
|
||
| async getAllBalances( |
There was a problem hiding this comment.
Could you mark
sui/sdk/typescript/src/providers/json-rpc-provider.ts
Lines 447 to 461 in e97e9cb
getAllBalances?
Comment on lines
25
to
30
| coin::mint_and_transfer<TEST_COIN>(&mut treasury_cap, 5, tx_context::sender(ctx), ctx); | ||
| coin::mint_and_transfer<TEST_COIN>(&mut treasury_cap, 6, tx_context::sender(ctx), ctx); | ||
|
|
||
| transfer::share_object(metadata); | ||
| transfer::share_object(treasury_cap) | ||
|
|
There was a problem hiding this comment.
I think this is pretty similar to the existing data/coin_metadata. Can we add these to the existing file instead of creating a new one?
| @@ -48,6 +48,7 @@ export type CoinMetadata = Infer<typeof CoinMetadataStruct>; | |||
| * Utility class for 0x2::coin | |||
| * as defined in https://github.com/MystenLabs/sui/blob/ca9046fd8b1a9e8634a4b74b0e7dabdc7ea54475/sui_programmability/framework/sources/Coin.move#L4 | |||
| */ | |||
|
|
|||
sdk/typescript/src/types/coin.ts
Outdated
Comment on lines
26
to
37
| export const BalanceStruct = object({ | ||
| coinType: string(), | ||
| coinObjectCount: number(), | ||
| totalBalance: number(), | ||
| lockedBalance: object({epochId: optional(number()), number: optional(number())}) | ||
| }); | ||
|
|
||
| export type BalanceStruct = Infer<typeof BalanceStruct>; | ||
|
|
||
| export const SupplyStruct = object({ | ||
| value: number() | ||
| }); |
There was a problem hiding this comment.
I would call these CoinBalance and CoinSupply instead of *struct since struct does not convey any meaning here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.