Explorer validator sorting #7481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mamos-mysten
force-pushed
the
explorer-validator-sorting
branch
from
f87ad66 to
2effabc
Compare
mamos-mysten
previously requested changes
Jan 20, 2023
Jibz1
force-pushed
the
explorer-validator-sorting
branch
from
2effabc to
2581fc0
Compare
Jordan-Mysten
approved these changes
Jan 22, 2023
| { | ||
| header: '#', | ||
| accessorKey: 'number', | ||
| cell: (props: any) => ( |
There was a problem hiding this comment.
Don't love the any's here. We can follow-up later with an improved Table component, just want to call it out
apps/explorer/src/ui/TableCard.tsx
Outdated
| onClick={ | ||
| column.columnDef.enableSorting | ||
| ? column.getToggleSortingHandler() | ||
| : void 0 |
mamos-mysten
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-01-20.at.9.17.20.AM.mov