Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated move.toml topic to include description of addr_subst #7428

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

ronny-mysten
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jan 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Jan 17, 2023 at 4:00PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Jan 17, 2023 at 4:00PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Jan 17, 2023 at 4:00PM (UTC)

@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Jan 16, 2023
Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the comment about the description of the git field being overly constrained, but otherwise this looks great, thanks @ronny-mysten !


```
<string> = { local = <string>, addr_subst* = { (<string> = (<string> | "<hex_address>"))+ } } # local dependencies
<string> = { git = <URL ending in .git>, subdir = <path to dir containing Move.toml inside git repo>, rev = <git commit hash>, addr_subst* = { (<string> = (<string> | "<hex_address>"))+ } } # git dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git field here does not have to always contain a URL that ends in .git. It can contain and URL, or filepath that points to a git repo (i.e. you should be able to call git clone with this field).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTK. Will update.

Comment on lines 85 to 86
bd = "0x08f5f5f4101e9c4b2d2b3f212b6e909b48acd02b"
cd = "0x08f5f5f4101e9c4b2d2b3f212b6e909b48acd02c"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would maybe pick two addresses that were more obviously different -- the last character is easy to miss here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggled with that, too. Will change.

@ronny-mysten ronny-mysten merged commit 69413f9 into MystenLabs:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants