Wallet validator unstaking1 #7403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Jordan-Mysten
requested changes
Jan 15, 2023
Jibz1
force-pushed
the
wallet-validator-unstaking1
branch
from
4418bae to
520e272
Compare
|
|
Jibz1
force-pushed
the
wallet-validator-unstaking1
branch
from
bc98a86 to
9beb49c
Compare
Jordan-Mysten
approved these changes
Jan 17, 2023
| validatorAddress: SuiAddress; | ||
| } | ||
|
|
||
| export function useStakeTokenMutation() { |
There was a problem hiding this comment.
A couple things with this:
- I'd actually be okay if this was just defined inline and not in a separate file.
- This file is named
useStakingMutationbut that hook isn't actually exposed. Maybe rename to something likestakingHooks?
| if (unstake) return; | ||
| const response = await dispatch( | ||
| stakeTokens({ | ||
| let response; |
There was a problem hiding this comment.
Not a blocking concern, but I think this could be done a little cleaner with onCompleted handlers in the mutation. Don't bother changing now, we can improve this later.
Jibz1
force-pushed
the
wallet-validator-unstaking1
branch
from
a8ad5a8 to
670bf63
Compare
Jibz1
force-pushed
the
wallet-validator-unstaking1
branch
from
670bf63 to
5ab752d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep getting this error on devnet
Error: Error in getValidators: Error: RPC Error: The response returned from RPC server does not match the TypeScript definition. This is likely because the SDK version is not compatible with the RPC server. Please update your SDK version to the latest. ...but works fine locally .Screen.Recording.2023-01-14.at.9.16.24.AM.mov