validator: add voting power #7392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
emmazzz
force-pushed
the
add_voting_power
branch
2 times, most recently
from
6a2b0c5 to
89df47c
Compare
sblackshear
reviewed
Jan 13, 2023
Good catch. Will rename. No changes required on the Rust side since we don't use this number directly on the Rust side. |
emmazzz
force-pushed
the
add_voting_power
branch
2 times, most recently
from
096448b to
3d3f985
Compare
lxfind
reviewed
Jan 14, 2023
| @@ -568,25 +585,17 @@ module sui::validator_set { | |||
| fun calculate_total_stake_and_quorum_threshold(validators: &vector<Validator>): (u64, u64, u64) { | |||
| let validator_state = 0; | |||
| let delegate_stake = 0; | |||
| let total_voting_power = 0; | |||
There was a problem hiding this comment.
This function no longer makes sense in that it's mixing the sum of stake and voting power threshold together, that's strange.
We should separate computations based on stake and computations based on voting power
emmazzz
force-pushed
the
add_voting_power
branch
from
3d3f985 to
a2ace7c
Compare
emmazzz
force-pushed
the
add_voting_power
branch
from
a2ace7c to
70fb738
Compare
sblackshear
approved these changes
Jan 14, 2023
lxfind
pushed a commit
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.