Update sui-move-library.md #7247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suggest better wording add some extra info
georgescharlesbrain
requested review from
randall-Mysten and
ronny-mysten
as code owners
randall-Mysten
approved these changes
Jan 9, 2023
|
Hello @randall-Mysten |
|
nope, just one approval. Ronny is another tech writer here, so it assigns both of us to any PR that changes a .md file. |
randall-Mysten
approved these changes
Jan 10, 2023
|
@randall-Mysten |
georgescharlesbrain
requested review from
randall-Mysten
and removed request for
ronny-mysten
randall-Mysten
approved these changes
Jan 12, 2023
|
Still didn't merge it seems :) |
Checking, looks like it is unhappy about the tests not completing but they are also not running. Or it cleared my Approval for some reason. |
randall-Mysten
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggest better wording
add some extra info