Update build-test.md #7235
Update build-test.md #7235
Conversation
correct test with filter
no change is required to the imports
bug running code --> simplify code
sword_create(&mut forge, 42, 7, initial_owner, test_scenario::ctx(scenario));
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
│ │ │
│ │ Found 5 argument(s) here
│ Invalid call of '(my_first_package=0x0)::my_module::sword_create'. The call expected 4 argument(s) but got 5
georgescharlesbrain
requested review from
randall-Mysten and
ronny-mysten
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
github-actions
bot
added
the
Type: Documentation
|
thanks @georgescharlesbrain Adding another reviewer |
There was a problem hiding this comment.
A small comment/question about a section that was removed, but otherwise, LGTM. Thanks for contributing @georgescharlesbrain !
| @@ -247,19 +250,9 @@ The code of the new functions is self-explanatory and uses struct | |||
| creation and Sui-internal modules (`TxContext` and `Transfer`) in a | |||
| way similar to what we have seen in the previous sections. The | |||
| important part is for the entry functions to have correct signatures | |||
| as described [earlier](index.md#entry-functions). In order for this code to | |||
There was a problem hiding this comment.
I couldn't figure out why this exposition wasn't necessary anymore -- the entry functions do introduce a reference to TxContext. Having said that, one clean-up you can now make is to remove the unreferenced _ctx: &mut TxContext parameter from sword_transfer as entry functions are now allowed to omit that parameter if it goes unused.
There was a problem hiding this comment.
Because I was not required to do this part.
Earlier in the tutorial at defining the package I had already imported TxContext. Mentioning that you first need to import a struct before using it was already clear at this stage in the tutorials.
I'll leave the _ctx: &mut TxContext parameter in for now.
georgescharlesbrain
requested review from
amnn
and removed request for
randall-Mysten and
ronny-mysten
There was a problem hiding this comment.
Thanks for answering my query @georgescharlesbrain. We still need @randall-Mysten or @ronny-mysten to review the copy, so adding them back -- the PR is all good from my side.
correct test with filter
no change is required to the imports
bug running code --> simplify code
Why is the forge object required? This can't be passed to sword_create...
Already got my answer by continuing with the tutorial.
Code simplification is desired here though. So the code actually runs at this stage in the tutorial.