Sui JSON support optional input

[patrickkuo]

a fix to enable optional input via sui json.

example:

call --package 0x2 --module sui_system --function request_add_delegation_mul_coin --args 0x5 [0x75a556740fb6e45219b1069ca08143ab086e9283, 0x907ae3c07cba82c26e363097e56f2aa0837547c2, 0xcf9b1967ee44e060c36a9b93d8075a0ccefce803] [200000000000000] 0x0879e3ec427b091fc22c1f765fdec22ea71a2150 --gas-budget 10000

We are using array to represent optional values, empty array [] indicate None.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated
explorer-storybook	⬜️ Ignored (Inspect)			Jan 11, 2023 at 4:58PM (UTC)
wallet-adapter	⬜️ Ignored (Inspect)			Jan 11, 2023 at 4:58PM (UTC)

[sblackshear]

LGTM, thanks!

[awelc]

LGTM as well, but I think we should document this in https://github.com/MystenLabs/sui/blob/main/doc/src/reference/sui-json.md

[tnowacki]

Thanks! I think this solves #7142?

[patrickkuo]

Thanks! I think this solves #7142?

Yes.

But I will revert the changes in Sui JSON and move the u64 to String magic to the CLI, the u64 String checks in Sui JSON is correct.

[patrickkuo]

Moved the u64 -> String conversion to the CLI, also added more e2e tests.

Sui Json will continue to enforce u64 String.

[patrickkuo]

LGTM as well, but I think we should document this in https://github.com/MystenLabs/sui/blob/main/doc/src/reference/sui-json.md

I am not changing the Sui JSON u64 string enforcement logic, so don't need to change the doc.

[awelc]

I am not changing the Sui JSON u64 string enforcement logic, so don't need to change the doc.

I was thinking of documenting how to encode Option in the Type coercion rules section unless you can think of a better place where developers would be able to find this info.

[patrickkuo]

I am not changing the Sui JSON u64 string enforcement logic, so don't need to change the doc.

I was thinking of documenting how to encode Option in the Type coercion rules section unless you can think of a better place where developers would be able to find this info.

ah! of course! will add that

[patrickkuo]

hi @awelc, does this looks ok to you?