[Stress] fix local benchmark; run benchmark in release mode #6930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lxfind
approved these changes
Dec 20, 2022
mwtian
changed the title
sadhansood
reviewed
Dec 20, 2022
| @@ -325,6 +328,9 @@ async fn main() -> Result<()> { | |||
| } | |||
| } | |||
| join_all(follower_handles).await; | |||
| loop { | |||
There was a problem hiding this comment.
Could we add a comment about why this is necessary? Thanks! - iiuc, It's mostly for server warmup?
There was a problem hiding this comment.
Added. This is to keep Sui validators alive.
sadhansood
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As chatted with @lxfind, add an infinite wait for server runtime thread in stress client. This fixes the issue here: https://github.com/MystenLabs/sui/actions/runs/3735884139/jobs/6339625259#step:8:944
Add a smoke test for benchmark in CI.
Build stress benchmark in release mode in the benchmark workflow.