wallet-ext: keyring fix locking and reviving race condition #6848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when it's time to lock the keyring due to inactivity there is a race condition between reviving from session storage and locking because of the alarm. (Keyring is trying to revive since bg service wakes up to respond to the alarm and before completing we lock it) * this fixes it by waiting reviving to complete before locking * this only happens if bg service was inactive before the alarm was triggered
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3709140308#artifacts |
Jordan-Mysten
approved these changes
Dec 16, 2022
pchrysochoidis
deleted the
pc-wallet-ext-keyring-fix-lock-revive-race
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: APPS-302