Create a JSON RPC API for threshold-BLS signing & add the Randomness Move module #6824

benr-ml · 2022-12-15T11:51:30Z

Implementation of TBlsSignatureApi and the Move side according to the HLD. Currently computes everything locally, without calling f+1 validators.
Includes also examples of a lottery and an auto generated NFTs using owned objects.

vercel · 2022-12-15T11:51:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Updated
explorer	⬜️ Ignored (Inspect)	Jan 25, 2023 at 3:31PM (UTC)
explorer-storybook	⬜️ Ignored (Inspect)	Jan 25, 2023 at 3:31PM (UTC)
frenemies	⬜️ Ignored (Inspect)	Jan 25, 2023 at 3:31PM (UTC)
wallet-adapter	⬜️ Ignored (Inspect)	Jan 25, 2023 at 3:31PM (UTC)

crates/sui-json-rpc/src/api.rs

bmwill · 2022-12-15T23:18:29Z

crates/sui-json-rpc/src/unit_tests/rpc_server_tests.rs

@@ -94,6 +95,66 @@ async fn test_public_transfer_object() -> Result<(), anyhow::Error> {
    Ok(())
 }

+// TODO: WIP, complete this tests
+#[sim_test]


probably ok to have this be sui_test so it can be run under a bare cargo test

crates/sui-framework/sources/crypto/randomness.move

benr-ml · 2023-01-11T14:37:02Z

@damirka, this is the implementation of the Randomness object we discussed awhile ago. Would appreciate your review of the Move related files.

@bmwill, updated the PR after some changes I've done in fastcrypto that blocked this change. I'm planning to fix the TODO on verifying the effects cert in a follow up PR.

damirka

Amazing work! Move part is done well!

Left a few comments but feel free to ignore.

crates/sui-framework/tests/crypto/randomness_tests.move

crates/sui-framework/sources/crypto/randomness.move

crates/sui-framework/tests/crypto/randomness_tests.move

sui_programmability/examples/nfts/sources/random_word.move

sui_programmability/examples/games/tests/randomness_based_lottery_tests.move

damirka · 2023-01-25T00:12:49Z

crates/sui-framework/sources/crypto/randomness.move

+    const EInvalidRndLength: u64 = 2;
+
+    /// All signatures are prefixed with Domain.
+    const Domain: vector<u8> = b"randomness";


I'm not sure if this needs to be static or dynamic (probably former) but you can use type of the T as a signing parameter through type reflection:

let unique_type_signature: TypeName = std::type_name::get<T>(); // and then something like let bytes = sui::bcs::to_bytes(&unique_type_signature);

crates/sui-framework/sources/crypto/randomness.move

damirka · 2023-01-25T00:16:07Z

crates/sui-framework/sources/crypto/randomness.move

+    }
+
+    /// Verify signature sig on message msg using the epoch's BLS key.
+    native fun native_tbls_verify_signature(epoch: u64, msg: &vector<u8>, sig: &vector<u8>): bool;


Since these functions are relatively important (although not available publicly, it might be better to move them up for visibility).

patrickkuo

Some nits on error handling, otherwise LGTM

crates/sui-json-rpc/src/api.rs

patrickkuo · 2023-01-25T11:35:47Z

crates/sui-json-rpc/src/threshold_bls_api.rs

+            .await
+            .map_err(|e| anyhow!(e))?;
+        let ObjectRead::Exists(_obj_ref, obj, layout) = obj_read else {
+            Err(anyhow!("Object not found"))? };


if you return Result<Object,Error> instead of RpcResult, you can use a proper error (SuiError or sui-json-rpc::Error) instead of Err(anyhow!())?, e.g.

sui/crates/sui-json-rpc/src/coin_api.rs

Lines 40 to 42 in 2a3d285

async fn get_object(&self, object_id: &ObjectID) -> Result<Object, Error> {

Ok(self.state.get_object_read(object_id).await?.into_object()?)

}

I changed the function response (here and elsewhere) and used enums for "canonical errors" and anyhow for user specific ones.

crates/sui-json-rpc/src/threshold_bls_api.rs

patrickkuo

LGTM!

Co-authored-by: Damir Shamanaev <damirka.ru@gmail.com>

…Move module (#6824)

benr-ml changed the title ~~Create a JSON RPC API for threshold-BLS signing~~ [WIP] Create a JSON RPC API for threshold-BLS signing Dec 15, 2022

benr-ml mentioned this pull request Dec 15, 2022

[WIP] Add the Randomness object #6773

Closed

benr-ml force-pushed the ben/tbls_json_rpc branch from e03a2bf to cdfa0ab Compare December 15, 2022 19:58

bmwill reviewed Dec 15, 2022

View reviewed changes

benr-ml force-pushed the ben/tbls_json_rpc branch 6 times, most recently from 342cbbf to f93d4e2 Compare December 19, 2022 22:21

benr-ml changed the title ~~[WIP] Create a JSON RPC API for threshold-BLS signing~~ [WIP] Create a JSON RPC API for threshold-BLS signing & add the Randomness Move module Dec 20, 2022

benr-ml force-pushed the ben/tbls_json_rpc branch from 0ecf05e to dc39fc7 Compare December 25, 2022 13:02

benr-ml force-pushed the ben/tbls_json_rpc branch 2 times, most recently from 37446c3 to 2184b4b Compare January 8, 2023 18:26

benr-ml force-pushed the ben/tbls_json_rpc branch 2 times, most recently from f742c06 to 9fdeda3 Compare January 11, 2023 14:26

benr-ml commented Jan 11, 2023

View reviewed changes

crates/sui-framework/sources/crypto/randomness.move Outdated Show resolved Hide resolved

benr-ml marked this pull request as ready for review January 11, 2023 14:33

benr-ml requested review from randall-Mysten, ronny-mysten, joyqvq and kchalkias as code owners January 11, 2023 14:33

benr-ml requested review from bmwill and damirka January 11, 2023 14:33

benr-ml changed the title ~~[WIP] Create a JSON RPC API for threshold-BLS signing & add the Randomness Move module~~ Create a JSON RPC API for threshold-BLS signing & add the Randomness Move module Jan 11, 2023

benr-ml force-pushed the ben/tbls_json_rpc branch 3 times, most recently from 7ffb058 to 056c4ae Compare January 22, 2023 08:56

benr-ml requested a review from patrickkuo January 24, 2023 14:53

damirka approved these changes Jan 25, 2023

View reviewed changes

benr-ml force-pushed the ben/tbls_json_rpc branch from 7e7632b to 26fdd48 Compare January 25, 2023 08:45

patrickkuo reviewed Jan 25, 2023

View reviewed changes

benr-ml requested a review from patrickkuo January 25, 2023 14:59

patrickkuo approved these changes Jan 25, 2023

View reviewed changes

benr-ml and others added 13 commits January 25, 2023 17:14

impl

4aae51a

update documentation

42b88d7

update

e15d9ce

update

e9c2ec2

update

5eb4389

update test

a20d8d8

update

2535dfc

Apply suggestions from code review

789c849

Co-authored-by: Damir Shamanaev <damirka.ru@gmail.com>

address more comments

63a45ac

update

d441b57

update

9aa3ce4

add the json spec

c631d2b

update errors

1df407b

benr-ml force-pushed the ben/tbls_json_rpc branch from fdce2cf to 1df407b Compare January 25, 2023 15:15

fix clippy

c6dc4c6

benr-ml merged commit abb34e8 into main Jan 25, 2023

benr-ml deleted the ben/tbls_json_rpc branch January 25, 2023 15:55

williampsmith pushed a commit that referenced this pull request Feb 3, 2023

Create a JSON RPC API for threshold-BLS signing & add the Randomness …

38f9a69

…Move module (#6824)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a JSON RPC API for threshold-BLS signing & add the Randomness Move module #6824

Create a JSON RPC API for threshold-BLS signing & add the Randomness Move module #6824

benr-ml commented Dec 15, 2022 •

edited

Loading

vercel bot commented Dec 15, 2022 •

edited

Loading

bmwill Dec 15, 2022

benr-ml commented Jan 11, 2023 •

edited

Loading

damirka left a comment

damirka Jan 25, 2023

damirka Jan 25, 2023

patrickkuo left a comment

patrickkuo Jan 25, 2023

benr-ml Jan 25, 2023 •

edited

Loading

patrickkuo left a comment

	async fn get_object(&self, object_id: &ObjectID) -> Result<Object, Error> {
	Ok(self.state.get_object_read(object_id).await?.into_object()?)
	}

Create a JSON RPC API for threshold-BLS signing & add the Randomness Move module #6824

Create a JSON RPC API for threshold-BLS signing & add the Randomness Move module #6824

Conversation

benr-ml commented Dec 15, 2022 • edited Loading

vercel bot commented Dec 15, 2022 • edited Loading

bmwill Dec 15, 2022

Choose a reason for hiding this comment

benr-ml commented Jan 11, 2023 • edited Loading

damirka left a comment

Choose a reason for hiding this comment

damirka Jan 25, 2023

Choose a reason for hiding this comment

damirka Jan 25, 2023

Choose a reason for hiding this comment

patrickkuo left a comment

Choose a reason for hiding this comment

patrickkuo Jan 25, 2023

Choose a reason for hiding this comment

benr-ml Jan 25, 2023 • edited Loading

Choose a reason for hiding this comment

patrickkuo left a comment

Choose a reason for hiding this comment

benr-ml commented Dec 15, 2022 •

edited

Loading

vercel bot commented Dec 15, 2022 •

edited

Loading

benr-ml commented Jan 11, 2023 •

edited

Loading

benr-ml Jan 25, 2023 •

edited

Loading