Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet-adapter] Reorganize wallet adapter #6699

Merged
merged 4 commits into from
Dec 9, 2022
Merged

[wallet-adapter] Reorganize wallet adapter #6699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
246d25a
Reoranize wallet adapter
Jordan-Mysten Dec 9, 2022
87cbf44
Remove dependency
Jordan-Mysten Dec 9, 2022
b8d5664
Fix missing deps
Jordan-Mysten Dec 9, 2022
36c68ce
formatg
Jordan-Mysten Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"ignore": [
"sui-explorer",
"sui-wallet",
"sui-wallet-adapter",
"sui-wallet-adapter-demo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why demo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the demo app for the wallet adapter, so we're marking to ignore it from versioning. Although future versions of changesets will mean we don't need to spell it out.

"@mysten/core"
]
}
23 changes: 11 additions & 12 deletions .github/workflows/wallet-adapter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,8 @@
name: Wallet Adapter PR Checks
on: pull_request
jobs:
diff:
runs-on: [ubuntu-latest]
outputs:
isWalletAdapter: ${{ (steps.diff.outputs.packages && contains(fromJson(steps.diff.outputs.packages), 'sui-wallet-adapter')) }}
steps:
- uses: actions/checkout@v3
- name: Detect Changes
uses: "./.github/actions/pnpm-diffs"
id: diff
ci:
name: Build
needs: diff
if: needs.diff.outputs.isWalletAdapter == 'true'
runs-on: [ubuntu-latest]
steps:
- name: Checkout
Expand All @@ -28,5 +17,15 @@ jobs:
cache: "pnpm"
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Turbo Cache
id: turbo-cache
uses: actions/cache@v3
with:
path: node_modules/.cache/turbo
key: turbo-${{ github.job }}-${{ github.ref_name }}-${{ github.sha }}
restore-keys: |
turbo-${{ github.job }}-${{ github.ref_name }}-

- name: Build
run: pnpm wallet-adapter build
run: pnpm turbo build --filter="./sdk/wallet-adapter/**"
16 changes: 7 additions & 9 deletions apps/explorer/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,24 @@
"@mysten/sui.js": ["../../sdk/typescript/src/"],
"@mysten/bcs": ["../../sdk/bcs/src/"],
"@mysten/wallet-adapter-base": [
"../../sdk/wallet-adapter/packages/adapters/base-adapter/src/"
"../../sdk/wallet-adapter/adapters/base-adapter/src/"
],
"@mysten/wallet-standard": [
"../../sdk/wallet-adapter/packages/wallet-standard/src/"
"../../sdk/wallet-adapter/wallet-standard/src/"
],
"@mysten/wallet-adapter-all-wallets": [
"../../sdk/wallet-adapter/packages/adapters/all-wallets/src/"
"../../sdk/wallet-adapter/adapters/all-wallets/src/"
],
"@mysten/wallet-adapter-unsafe-burner": [
"../../sdk/wallet-adapter/packages/adapters/unsafe-burner/src/"
"../../sdk/wallet-adapter/adapters/unsafe-burner/src/"
],
"@mysten/wallet-adapter-wallet-standard": [
"../../sdk/wallet-adapter/packages/adapters/wallet-standard-adapter/src/"
"../../sdk/wallet-adapter/adapters/wallet-standard-adapter/src/"
],
"@mysten/wallet-adapter-react": [
"../../sdk/wallet-adapter/packages/react-providers/src/"
"../../sdk/wallet-adapter/react-providers/src/"
],
"@mysten/wallet-kit": [
"../../sdk/wallet-adapter/packages/wallet-kit/src/"
]
"@mysten/wallet-kit": ["../../sdk/wallet-adapter/wallet-kit/src/"]
}
},
"include": ["src"]
Expand Down
2 changes: 1 addition & 1 deletion apps/wallet/configs/ts/tsconfig.common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@mysten/sui.js": ["../../sdk/typescript/src/"],
"@mysten/bcs": ["../../sdk/bcs/src/"],
"@mysten/wallet-standard": [
"../../sdk/wallet-adapter/packages/wallet-standard/src/"
"../../sdk/wallet-adapter/wallet-standard/src/"
]
}
},
Expand Down
Loading