[narwhal] add log statements to easily trace when tasks shutdown #6696
Conversation
narwhal/consensus/src/consensus.rs
Outdated
| spawn_monitored_task!(s.run()).tap(|_| { | ||
| info!("Consensus task shutdown"); | ||
| }) |
There was a problem hiding this comment.
This does not do what you think it does. This will immediately return and print the log statement.
There was a problem hiding this comment.
If you want a statement to be printed when the task itself finishes, you'll want to directly instrument the future that's being spawned.
There was a problem hiding this comment.
oh my that's embarrassing - can't even think why I did it this way - I'll refactor , thanks @bmwill !
There was a problem hiding this comment.
haha no worries, i've made similar mistakes before which is why i knew this wouldn't do what you want it to :)
There was a problem hiding this comment.
I would have made the same mistake! Thanks @bmwill
narwhal/consensus/src/consensus.rs
Outdated
| spawn_monitored_task!(s.run()).tap(|_| { | ||
| info!("Consensus task shutdown"); | ||
| }) |
There was a problem hiding this comment.
I would have made the same mistake! Thanks @bmwill
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
akichidis
force-pushed
the
refactor/add-tasks-info-logs
branch
from
1baf3aa to
167054a
Compare
This PR extends the
spawn_monitored_taskmacro and introduces thespawn_logged_monitored_taskin order to provide extra capabilities to print log statements when the passed in task future starts/ends. It also introduces the ability to add names for our tasks so we can easily identify them