ts-sdk: Add getTransactionAuthSigners json rpc #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyqvq
force-pushed
the
get-auth-signers
branch
from
85a56d9 to
94a4727
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3632917093#artifacts |
joyqvq
force-pushed
the
get-auth-signers
branch
from
94a4727 to
568a517
Compare
joyqvq
force-pushed
the
get-auth-signers
branch
from
568a517 to
56718bb
Compare
joyqvq
force-pushed
the
get-auth-signers
branch
from
56718bb to
dc51339
Compare
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3633259228#artifacts |
666lcz
approved these changes
Dec 7, 2022
| ); | ||
| const digest = resp.data[0]; | ||
| const version = await toolbox.provider.getRpcApiVersion(); | ||
| if (version?.major === 0 && version?.minor > 17) { |
There was a problem hiding this comment.
nit: I would put this check before fetching the transaction
| if (version?.major === 0 && version?.minor > 17) { | ||
| // This endpoint is only available in 0.18 and above | ||
| const res = await toolbox.provider.getTransactionAuthSigners(digest); | ||
| expect(res.signers.length).toEqual(3); |
There was a problem hiding this comment.
Can we change this to greater or equal to 3 so that it also work for TestNet?
joyqvq
force-pushed
the
get-auth-signers
branch
from
dc51339 to
99197db
Compare
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3642553727#artifacts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.