Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sui Json RPC Types: Return strings for u64 #6608

Merged
merged 5 commits into from
Dec 9, 2022
Merged

Sui Json RPC Types: Return strings for u64 #6608

merged 5 commits into from
Dec 9, 2022

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Dec 6, 2022 •
edited
Loading

This handles the first part of #2328
Which ensures that u64 types are represented as strings in Move call outputs.
This also indirectly implied removing ByteArray & Base64 in outputs.

Next steps in subsequent PRs:

  • remove the usage of LosslessJSON
  • replace the usage of the BN library with bigint
  • beyond Sui JSON, we need to make sure all u64 numbers are strings (example for gas used)

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
explorer ⬜️ Ignored (Inspect) Dec 6, 2022 at 5:32PM (UTC)

@oxade oxade requested a review from Jordan-Mysten December 8, 2022 21:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3653849887#artifacts

@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Dec 9, 2022
Closed
@oxade oxade marked this pull request as ready for review December 9, 2022 02:47
@oxade oxade changed the title return strings for u64 Sui Json RPC Types: Return strings for u64 Dec 9, 2022
patrickkuo
patrickkuo approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

666lcz
666lcz approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Jordan-Mysten
Jordan-Mysten approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@Jordan-Mysten Jordan-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallet and explorer changes LGTM!

@oxade oxade merged commit d60a989 into main Dec 9, 2022
@oxade oxade deleted the return_u64_strings_suijson_rpc_types branch December 9, 2022 19:12
@oxade oxade mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jordan-Mysten Jordan-Mysten Jordan-Mysten approved these changes

@gegaowp gegaowp gegaowp approved these changes

@666lcz 666lcz 666lcz approved these changes

@patrickkuo patrickkuo patrickkuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oxade @patrickkuo @666lcz @gegaowp @Jordan-Mysten