explorer: use wallet kit #6520
Merged
explorer: use wallet kit #6520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchrysochoidis
requested review from
Jibz1,
apburnie,
mystie711 and
Jordan-Mysten
pchrysochoidis
force-pushed
the
pc-explorer-apps-245-use-wallet-kit
branch
from
7ef90ea to
e8676e9
Compare
pchrysochoidis
force-pushed
the
pc-explorer-apps-245-use-wallet-kit
branch
from
e8676e9 to
69bf4d9
Compare
pchrysochoidis
force-pushed
the
pc-explorer-apps-245-use-wallet-kit
branch
from
69bf4d9 to
4cd5eb2
Compare
pchrysochoidis
force-pushed
the
pc-explorer-apps-245-use-wallet-kit
branch
from
4cd5eb2 to
c6ca12d
Compare
pchrysochoidis
force-pushed
the
pc-explorer-apps-245-use-wallet-kit
branch
from
c6ca12d to
5527b25
Compare
|
Looks like the wallet kit backdrop isn't visible, maybe needs a higher z-index? |
| connected ? st.connected : st.connect, | ||
| st.button | ||
| )} | ||
| type="button" |
There was a problem hiding this comment.
We should add this to the underlying wallet kit buttons
| } | ||
| size="md" | ||
| className={clsx( | ||
| connected ? st.connected : st.connect, |
There was a problem hiding this comment.
Can we use inline tailwind?
There was a problem hiding this comment.
I've used inline before but was't working properly when building in prod mode. Then moved it to css modules to apply !important. I'll see if I can do something better
There was a problem hiding this comment.
Done (inline and important)
pchrysochoidis
force-pushed
the
pc-explorer-apps-245-use-wallet-kit
branch
from
5527b25 to
b52ce99
Compare
pchrysochoidis
force-pushed
the
pc-explorer-apps-245-use-wallet-kit
branch
from
b52ce99 to
07b7486
Compare
Jordan-Mysten
approved these changes
Dec 4, 2022
| @@ -25,6 +25,15 @@ const argsSchema = z.object({ | |||
| params: z.array(z.object({ value: z.string().trim().min(1) })), | |||
| }); | |||
|
|
|||
| const connectButtonStyles = cva('!text-bodySmall !rounded-md', { | |||
There was a problem hiding this comment.
FWIW for cases like this, I think it's often cleaner to just use clsx inline. CVA is really for component definitions where we want to extract variant props, not for arbitrary application of classes.
There was a problem hiding this comment.
Makes sense thanks! I will update it
* the account modal was visible for a bit after connecting to a wallet from the Connect modal before it closes. This fixes it.
* addresses PR comment * also fixes hover styling
pchrysochoidis
force-pushed
the
pc-explorer-apps-245-use-wallet-kit
branch
from
07b7486 to
ef119db
Compare
* fixes form validation
Jibz1
pushed a commit
that referenced
this pull request
Dec 7, 2022
* wallet-kit: prevent showing Account modal after connecting * the account modal was visible for a bit after connecting to a wallet from the Connect modal before it closes. This fixes it. * explorer: migrate to wallet-kit * wallet-kit: dialog backdrop visible and clickable * explorer: use clsx instead of cva * addresses PR comment * also fixes hover styling * explorer: fixes executing tx for functions with no arguments * fixes form validation * wallet-kit: connect button defaults to type button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the issue
Screen.Recording.2022-12-01.at.20.58.52.mov
and makes wallet-kit backdrop clickable and visible
Screen.Recording.2022-12-02.at.11.52.10.mov
Screen.Recording.2022-12-02.at.11.52.58.mov
Screen.Recording.2022-12-02.at.11.55.57.mov
Closes: APPS-245