Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change transfer_object to transfer_coin in Client API #647

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Mar 3, 2022

As described in #612 , we only support native transfer of the coin objects, and we don't intend to support native transfer of arbitrary objects in the near term (maybe until we figure out how to use capability to express transferability of Move struct types).
This PR updates the Client API to reflect this restriction.
Also cleaned up the checks on the authority side for code reuse.

Do we also need to make any document changes?

@gdanezis
Copy link
Collaborator

gdanezis commented Mar 4, 2022

Quick question: why are we being special about this? Why not also handle coin transfers through the move transfer path? And then optimize this? We could get rid of quite some code no? (And I love deleting code).

@lxfind
Copy link
Contributor Author

lxfind commented Mar 4, 2022

We totally could. If we don't have a native transfer today then we probably would hold off optimizing it until we see data. But since we have it today, I would also hold off de-optimizing it until we have data.
Intuitively it makes sense to me to have a significantly cheaper way for coin (gas included) transfers as it is likely to be common enough. But I am happy to delete latter once we are sure we don't need to add it back.

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Make sense to keep this clean (until we delete it).

Do we also need to make any document changes?

I have not noticed any.

@lxfind lxfind force-pushed the limit-transfer-coin branch from 79ea734 to 4793ecb Compare March 4, 2022 20:14
@lxfind lxfind merged commit ae842e2 into main Mar 4, 2022
@lxfind lxfind deleted the limit-transfer-coin branch March 4, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants