Implement the move module for cross-chain airdrop

[666lcz]

This PR implements the Move component as mentioned in the NFT Mirroring design doc . The goal of this PR is not to write a rigorous and production ready contract with all the features in ERC-721 standard, but just to have a minimal version to unblock the MVP before GDC.

The major TODOs are(in separate PRs)

• Represent token_id in u256 (see discussion in [RFC] Add Starcoin-framework as a dependency #616)
• Implement the Sparse Set. Right now the time complexity for checking the uniqueness of (eth_contract_address, eth_token_id) is O(M+N) where M is the number of mirrored ETH contracts and N is the max number of claimed token ids for a given eth contract address). Implementing the sparse set will reduce the time complexity to O(1) but will take more efforts.

[666lcz]

I received the following compiler error

➜ cargo test
    Finished test [unoptimized + debuginfo] target(s) in 0.51s
     Running unittests (/Users/cl/ml/fastnft/target/debug/deps/sui_framework-e9d21590967f6d70)

running 2 tests
bug[ICE12001]: BYTECODE GENERATION FAILED
  ┌─ /Users/cl/ml/fastnft/sui_programmability/framework/../examples/../framework/sources/CrossChainAirdrop.move:5:13
  │
5 │ module Sui::CrossChainAirdrop {
  │             ^^^^^^^^^^^^^^^^^ IR ERROR: TODO Structs are not *yet* supported in constant type layouts

error: test failed, to rerun pass '--lib'

Does anyone know what does this mean?

UPDATE:

resolved in https://mysten-labs.slack.com/archives/C02DRAL32GN/p1646256086677789

[lxfind]

Very nice!
A few nits.

[oxade]

Hard requirement: TxContext must be last arg for entry functions.
Format is: [ObjectArgs.... Pure/Primitive Args... TxContext]

[oxade]

Another request:
Sorry for holding up the PR.
I think if a module has entry functions it is important that we test exercising the functions from systems outside of Move (CLI tests, Client unit tests, Authority unit tests, etc) for the following reasons:

1. It shows others how to use the contract without understanding Move details
2. It proves that the contract entry functions are conformant
3. It helps us exercise our linter (and in future pre-execution logic)

For examples see https://github.com/MystenLabs/fastnft/blob/main/sui/src/unit_tests/cli_tests.rs#L557
https://github.com/MystenLabs/fastnft/blob/main/sui_core/src/unit_tests/client_tests.rs#L855

[oxade]

I think you can still compare ASCII bytes right?

[666lcz]

I have a hard time figuring out how to convert serde_json::Value to bytes, let me know if you know how to do it

[oxade]

Looks good!
Only a some renaming nits that may cause ambiguity, and one test case that could be more complete, but overall looks good, thanks for updating the tests!