Wait for remote peer connections in Core recovery header fetch #6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akichidis
approved these changes
Nov 14, 2022
|
This broke some tests in integration_tests_validator_api because now a 1s sleep is not sufficient for core startup to finish before the test proceeds. I'll need to fix that before merging |
Uses `WaitingPeer` to wait up to the already-configured timeout before giving up on remote header fetch on Core recovery.
aschran
force-pushed
the
aschran/recover
branch
from
0b15089 to
2953a7b
Compare
ebmifa
pushed a commit
that referenced
this pull request
Nov 14, 2022
Uses `WaitingPeer` to wait up to the already-configured timeout before giving up on remote header fetch on Core recovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
WaitingPeerto wait up to the already-configured timeout before giving up on remote header fetch on Core recovery.