Edit new SuiJSON page #610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code format values Format table headers Make small edits to the text
oxade
reviewed
Mar 4, 2022
huitseeker
suggested changes
Mar 4, 2022
There was a problem hiding this comment.
Good formatting changes overall, but @ade's comment applies I think, JSON had a limited number of value types, we shove everything else into a string, which means we need to represent it with explicit double quotes.
Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Adding quotes back Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
|
Francois, you are a life saver for reverting my foolishness. And thanks for catching, Ade. I think all is better now. Note, I'm seeking to revert PR #664 where I've moved this file to get this in. Sorry for the churn. |
Clay-Mysten
commented
Mar 7, 2022
|
Closing in favor of: |
Merged
mwtian
added a commit
that referenced
this pull request
Sep 12, 2022
* snapshot test Parameters::import() and fix typos * ignore git precommit hook * add instructions
mwtian
added a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
* snapshot test Parameters::import() and fix typos * ignore git precommit hook * add instructions
This was referenced Nov 10, 2022
This was referenced Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code format values
Format table headers
Make small edits to the text