Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force frame pointers in release builds #6055

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Force frame pointers in release builds #6055

merged 1 commit into from
Nov 11, 2022

Conversation

mystenmark
Copy link
Contributor

This will make it easier to capture profiles of running release builds. I believe it will also make the jeprof traces we capture readable.

@mystenmark mystenmark requested review from bmwill and mwtian November 11, 2022 22:48
mwtian
mwtian approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@mwtian mwtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this helps. To make the profile truly readable, e.g. include inlined frames, we need debug info in the binary or when generating profiles. I do obtain a few usable profiles, which I will share soon.

@mystenmark mystenmark merged commit c5f7566 into main Nov 11, 2022
@mystenmark mystenmark deleted the mlogan-frame-pointers branch November 11, 2022 23:09
mwtian pushed a commit that referenced this pull request Nov 15, 2022
@mystenmark @mwtian
Force frame pointers in release builds (#6055)
acfc068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwtian mwtian mwtian approved these changes

@bmwill bmwill Awaiting requested review from bmwill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mystenmark @mwtian