Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: AuthoritySignature commits to epoch id #6024

Merged
merged 1 commit into from
Nov 14, 2022
Merged

crypto: AuthoritySignature commits to epoch id #6024

merged 1 commit into from
Nov 14, 2022

Conversation

joyqvq
Copy link
Contributor

@joyqvq joyqvq commented Nov 10, 2022 •
edited
Loading

@joyqvq joyqvq force-pushed the epochid-2 branch 3 times, most recently from 4058546 to abd9704 Compare November 10, 2022 21:02
@joyqvq joyqvq requested a review from lxfind November 10, 2022 22:42
@joyqvq joyqvq marked this pull request as ready for review November 10, 2022 22:42
@joyqvq joyqvq requested a review from huitseeker as a code owner November 10, 2022 22:42
kchalkias
kchalkias reviewed Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@kchalkias kchalkias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooc why do we need to commit to epochID if we always rotate validator keys per epoch? Maybe the assumption is that we might maintain the same key(s) in the next epoch?

@lxfind
Copy link
Contributor

lxfind commented Nov 11, 2022

Is there a plan to use different key for each validator at each epoch?

@joyqvq
Copy link
Contributor Author

joyqvq commented Nov 11, 2022

Is there a plan to use different key for each validator at each epoch?

not that I am aware of, its a good idea though, but require some non-trivial work.

@joyqvq joyqvq requested a review from kchalkias November 11, 2022 21:17
@joyqvq joyqvq merged commit 4935cdb into main Nov 14, 2022
@joyqvq joyqvq deleted the epochid-2 branch November 14, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchalkias kchalkias kchalkias approved these changes

@lxfind lxfind Awaiting requested review from lxfind

@huitseeker huitseeker Awaiting requested review from huitseeker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyqvq @lxfind @kchalkias