explorer-show-recent-package-component #6007
Conversation
Jibz1
commented
Nov 10, 2022
•
Jibz1
commented
Jibz1
requested review from
apburnie,
mystie711,
Jordan-Mysten and
pchrysochoidis
|
The Figma designs have the section lower down on the page, |
Jibz1
changed the title
apps/explorer/src/components/recent-packages-card/RecentPackagesCard.tsx
Show resolved
Hide resolved
apps/explorer/src/components/recent-packages-card/RecentPackagesCard.tsx
Outdated
Show resolved
Hide resolved
apps/explorer/src/components/recent-packages-card/RecentPackagesCard.tsx
Outdated
Show resolved
Hide resolved
| time: <TxTimeType timestamp={timestamp} />, | ||
|
|
||
| sender: ( | ||
| <Link |
There was a problem hiding this comment.
I'd be open to a new InternalLink (probably need a better name) that took a type like address, object, etc and linked there, and also managed consistent truncation. Basically LongText but rebuilt on new UI components.
You don't need to do this now, we can create a backlog item for it.
There was a problem hiding this comment.
Agreed, we can just build that out later.
apps/explorer/src/components/recent-packages-card/RecentPackagesCard.tsx
Outdated
Show resolved
Hide resolved
| timestamp: number | undefined; | ||
| }; | ||
|
|
||
| export function TxTimeType({ timestamp }: Prop) { |
There was a problem hiding this comment.
We could also make this a base UI component and port over the time utilities.
There was a problem hiding this comment.
Agreed. I wanted to get the high-priority done first.
There was a problem hiding this comment.
We can combine this component with the DateCard component on the other PR
Jibz1
force-pushed
the
explorer-recent-modules
branch
from
067f611 to
84fd4c3
Compare
| return recentPublishMod.data; | ||
| }, | ||
| { | ||
| staleTime: TRANSACTION_STALE_TIME, |
There was a problem hiding this comment.
Do we also want auto-refreshing here? cc @mystie711 curious what your thoughts are.
apps/explorer/src/components/recent-packages-card/RecentPackagesCard.tsx
Outdated
Show resolved
Hide resolved
apps/explorer/src/components/recent-packages-card/RecentPackagesCard.tsx
Outdated
Show resolved
Hide resolved
