Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[small] print hex checkpoint digest rather then Debug #5983

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

andll
Copy link
Contributor

@andll andll commented Nov 9, 2022

No description provided.

@andll andll requested review from lxfind, mwtian and mystenmark November 9, 2022 21:49
@andll andll enabled auto-merge (squash) November 9, 2022 21:50
Copy link
Contributor

@lxfind lxfind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a matter of implementing the Display trait for content digest?

@andll
Copy link
Contributor Author

andll commented Nov 9, 2022

Is this a matter of implementing the Display trait for content digest?

Unfortunately CheckpointDigest is a type alias for array, so we can't implement Display for it. Would have to change it to wrapper type (I can still do it a bit later, after removing checkpointv1 code, so that there is fewer changes)

@andll andll merged commit 3be0781 into main Nov 9, 2022
@andll andll deleted the andrey-56 branch November 9, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants