[core] Use Envelope for TransactionEffects #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lxfind
force-pushed
the
core-effects-use-envelope
branch
from
07b0d89 to
a59eb28
Compare
lxfind
force-pushed
the
core-effects-use-envelope
branch
2 times, most recently
from
e16df73 to
071a963
Compare
lxfind
force-pushed
the
core-effects-use-envelope
branch
from
071a963 to
e197590
Compare
|
ping :) |
lxfind
force-pushed
the
core-effects-use-envelope
branch
from
e197590 to
032ba63
Compare
joyqvq
reviewed
Nov 15, 2022
| @@ -1741,7 +1743,7 @@ where | |||
| ?tx_digest, | |||
| name=?name.concise(), | |||
| expected_epoch=?self.committee.epoch, | |||
| returned_epoch=?inner_signed.auth_sig().epoch, | |||
| returned_epoch=?inner_signed.epoch(), | |||
There was a problem hiding this comment.
whats the difference btw the epoch in auth sig vs the epoch?
There was a problem hiding this comment.
It's the same thing. Just a shortcut function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate effects envelope data structure. Main changes are in messages.rs. Rest are just refactorings.