Merge mysten_infra into sui repo #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfra#79) Improve the default and testing subscribers to include more information like the line number as well as outputting span creation and close events.
In many cases, e.g. cli tools like the wallet, a tool may want to print out some useful information to stdout. Today we currently log to stdout which makes it very difficult to distinguish between output we want the user to actually use and log messages. In order to address this this patch changes our logging infrastructure to log to stderr by default instead of stdout.
…log messages (MystenLabs/mysten-infra#85) * Remove unhelpful log messages * Don't use ansi colors unless stderr is a tty
…-infra#83) This commit is introducing an interface to act as a callback for performed requests against the server. Then those callbacks can be used for metrics reporting purposes.
* Add opening as secondary
As this is liable to overload memory, the present PR introduces an optional Predicate argument (a `Fn(&(Key, Value)) -> bool`) which allows filtering a subset of the table's items instead of the whole table.
…infra#94) Also fix our misuse of layering various optional tracing layers.
Improve our panic handler to do the following: Also call the stdlib's panic handler so backtraces aren't swallowed flush stdout and stderr enable configuring if the panic handler should crash the process
…llection of known PKs. (MystenLabs/mysten-infra#100) * add PskSet
…nLabs/mysten-infra#101) * add a ultility function to convert MultiAddr to SocketAddr * fixup! add a ultility function to convert MultiAddr to SocketAddr * add negative test * fixup! add negative test
sadhansood
changed the title
sadhansood
changed the title
sadhansood
force-pushed
the
sadhan/merge_mysten_infra
branch
from
8d20b47 to
a327fa8
Compare
|
Please move all these crates into the top level crates directory and not inside a special mysten-infra one. |
mwtian
reviewed
Nov 9, 2022
Cargo.toml
Outdated
| @@ -40,7 +40,29 @@ members = [ | |||
| "crates/test-utils", | |||
| "crates/workspace-hack", | |||
| "crates/x", | |||
| "narwhal/config", "narwhal/consensus", "narwhal/crypto", "narwhal/dag", "narwhal/examples", "narwhal/executor", "narwhal/network", "narwhal/node", "narwhal/primary", "narwhal/storage", "narwhal/test-utils", "narwhal/types", "narwhal/worker", | |||
| "mysten-infra/crates/component", | |||
There was a problem hiding this comment.
Can we use just one directory level for crates, e.g. mysten/ or infra/? Using crates/ as suggested would also work, but it will make fixing the Dockerfiles harder.
sadhansood
force-pushed
the
sadhan/merge_mysten_infra
branch
from
a327fa8 to
5617a34
Compare
sadhansood
force-pushed
the
sadhan/merge_mysten_infra
branch
from
5617a34 to
7a19011
Compare
sadhansood
force-pushed
the
sadhan/merge_mysten_infra
branch
from
7a19011 to
12bde63
Compare
sadhansood
force-pushed
the
sadhan/merge_mysten_infra
branch
from
12bde63 to
acfcf08
Compare
mwtian
reviewed
Nov 9, 2022
| @@ -16,7 +16,6 @@ jsonrpsee = { version = "0.15.1", features = ["full"] } | |||
| tracing = { version = "0.1.36", features = ["log"] } | |||
| clap = { version = "3.1.14", features = ["derive"] } | |||
| reqwest = { version = "0.11.11", features = ["blocking", "json"] } | |||
| telemetry-subscribers.workspace = true | |||
There was a problem hiding this comment.
Can we keep the workspace dependency setup? It will make it easier to put narwhal back into a separate repo.
There was a problem hiding this comment.
There are zero plans for putting narwhal back into a separate repo. This is not going to happen any time within the next 1-2 years
There was a problem hiding this comment.
I don't see any harm in using workspace dependency as before. There are people who want to experiment with narwhal in their projects too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge mysten-infra into sui. Followed steps used to merge narwhal closely here