Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax transaction input checker to not require signature #5855

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

gegaowp
Copy link
Contributor

@gegaowp gegaowp commented Nov 4, 2022

the input checker does not have to take a signed txn, the signature verification of prod txn execution path is done elsewhere.
here it is useful for dry_run_transaction, more context can be found in https://mysten-labs.slack.com/archives/C043CJH1HCK/p1667579885385269

@gegaowp gegaowp force-pushed the relax-tx-input-check branch from eb1b4ce to 0655a4f Compare November 4, 2022 19:07
Copy link
Collaborator

@sblackshear sblackshear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, thanks Ge!

@gegaowp gegaowp merged commit 298533d into MystenLabs:main Nov 4, 2022
@gegaowp gegaowp deleted the relax-tx-input-check branch November 4, 2022 23:47
@mystenmark
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants