[small] EffectsStore: take list of TransactionDigest instead of EffectDigests #5838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tDigests Currently `EffectsStore::get_effects()`` takes iterator of `ExecutionDigests`, extracts `TransactionDigest` and queries database. This PR changes API to take iterator of `TransactionDigest` directly, so that EffectsStore can be used to query effects when full `ExecutionDigests` is not known - this will be used in new checkpoints. #5763
andll
changed the title
mwtian
approved these changes
Nov 3, 2022
Jordan-Mysten
pushed a commit
to Jordan-Mysten/sui
that referenced
this pull request
Nov 4, 2022
…tDigests (MystenLabs#5838) Currently `EffectsStore::get_effects()`` takes iterator of `ExecutionDigests`, extracts `TransactionDigest` and queries database. This PR changes API to take iterator of `TransactionDigest` directly, so that EffectsStore can be used to query effects when full `ExecutionDigests` is not known - this will be used in new checkpoints. MystenLabs#5763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
EffectsStore::get_effects()takes iterator ofExecutionDigests, extractsTransactionDigestand queries database.This PR changes API to take iterator of
TransactionDigestdirectly, so that EffectsStore can be used to query effects when fullExecutionDigestsis not known - this will be used in new checkpoints.#5763