Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More instrument adapter #5588

Merged
merged 3 commits into from
Oct 27, 2022
Merged

More instrument adapter #5588

merged 3 commits into from
Oct 27, 2022

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Oct 27, 2022

No description provided.

@oxade oxade requested review from velvia and sblackshear October 27, 2022 01:11
velvia
velvia approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@velvia velvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think the level should probably be trace.

@oxade oxade enabled auto-merge (squash) October 27, 2022 01:55
@oxade
Copy link
Contributor Author

oxade commented Oct 27, 2022

Thanks. I think the level should probably be trace.

changed

@oxade oxade merged commit 4dd9e78 into main Oct 27, 2022
@oxade oxade deleted the adapter_exec_engine_instrumentation branch October 27, 2022 02:09
ebmifa pushed a commit that referenced this pull request Oct 27, 2022
@oxade @ebmifa
More instrument adapter (#5588)
cce8063 
* instrument adapter publish, execute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velvia velvia velvia approved these changes

@sblackshear sblackshear Awaiting requested review from sblackshear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxade @velvia