-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Explorer] Adds Sender / Recipients / Amount data to Pay transaction type #5570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @Andrew47.
For mobile, may i request we add the same amount of minimum padding as what we have on left so there is more breathing room for the text to wrap?
0b390dc
to
497f7e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the other comments.
@Jordan-Mysten, Switching to useQuery will take some time. Could you please explain the benefits of switching to |
@Andrew47 I don't think it should take more than 15-30 minutes to update this code to use it. We're moving all data fetching to it, it's an epic in Jira that we'll continually add migration tasks for. If you're interested in learning more I suggest reading the docs: https://tanstack.com/query/v4 |
I like the idea of data caching. I've switched the useEffect for useQuery and used the 'Heading' components. |
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3378176878#artifacts |
This PR adds a list of recipients and amounts sent for the Pay Transaction Type. The wonky display when examining a single sender and recipient is also fixed
One sender many recipients
Before
After
On Galaxy Fold
One sender one recipient
Before
After
On Galaxy Fold