Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explorer] Adds Sender / Recipients / Amount data to Pay transaction type #5570

Merged
merged 33 commits into from
Nov 2, 2022

Conversation

apburnie
Copy link
Contributor

@apburnie apburnie commented Oct 26, 2022

This PR adds a list of recipients and amounts sent for the Pay Transaction Type. The wonky display when examining a single sender and recipient is also fixed

One sender many recipients

Before

Screenshot 2022-10-26 at 16 01 18

After

Screenshot 2022-10-31 at 12 51 51

On Galaxy Fold

Screenshot 2022-10-31 at 12 52 42

One sender one recipient

Before

Screenshot 2022-10-26 at 16 02 26

After

Screenshot 2022-10-31 at 12 53 24

On Galaxy Fold

Screenshot 2022-10-31 at 12 56 23

@apburnie apburnie marked this pull request as ready for review October 27, 2022 16:01
Copy link
Collaborator

@mystie711 mystie711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @Andrew47.
For mobile, may i request we add the same amount of minimum padding as what we have on left so there is more breathing room for the text to wrap?

Copy link
Contributor

@Jordan-Mysten Jordan-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the other comments.

@apburnie
Copy link
Contributor Author

apburnie commented Oct 31, 2022

Please address the other comments.

@Jordan-Mysten, Switching to useQuery will take some time. Could you please explain the benefits of switching to useQuery so that I am using this new technology appropriately?

@Jordan-Mysten
Copy link
Contributor

@Andrew47 I don't think it should take more than 15-30 minutes to update this code to use it. We're moving all data fetching to it, it's an epic in Jira that we'll continually add migration tasks for. If you're interested in learning more I suggest reading the docs: https://tanstack.com/query/v4

@apburnie
Copy link
Contributor Author

apburnie commented Nov 1, 2022

@Andrew47 I don't think it should take more than 15-30 minutes to update this code to use it. We're moving all data fetching to it, it's an epic in Jira that we'll continually add migration tasks for. If you're interested in learning more I suggest reading the docs: https://tanstack.com/query/v4

I like the idea of data caching. I've switched the useEffect for useQuery and used the 'Heading' components.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3378176878#artifacts

@apburnie apburnie merged commit 9b95020 into main Nov 2, 2022
@apburnie apburnie deleted the PayTransaction branch November 2, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants