Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add get committe info in FN #5337

Merged
merged 2 commits into from
Oct 17, 2022
Merged

add get committe info in FN #5337

merged 2 commits into from
Oct 17, 2022

Conversation

longbowlu
Copy link
Collaborator

as title. This unblocks the work to use remote FN for txn submission in load gen

@longbowlu longbowlu requested a review from huitseeker as a code owner October 17, 2022 17:44
patrickkuo
patrickkuo approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this same as 0x5 object?

I thinks it's a good addition to the apis, LGTM

you probably need to regenerate the openrpc.json file

@lxfind
Copy link
Contributor

lxfind commented Oct 17, 2022

cc @joyqvq @gegaowp who might be interested

@longbowlu
Copy link
Collaborator Author

Is this same as 0x5 object?

I thinks it's a good addition to the apis, LGTM

you probably need to regenerate the openrpc.json file

yes, on the latest epoch, you can get this from 0x5

@longbowlu longbowlu enabled auto-merge (squash) October 17, 2022 18:12
@longbowlu longbowlu merged commit 17d3a2f into main Oct 17, 2022
@longbowlu longbowlu deleted the add-get-committee-info branch October 17, 2022 18:21
@joyqvq joyqvq mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickkuo patrickkuo patrickkuo approved these changes

@lxfind lxfind Awaiting requested review from lxfind

@mystenmark mystenmark Awaiting requested review from mystenmark

@huitseeker huitseeker Awaiting requested review from huitseeker

@randall-Mysten randall-Mysten Awaiting requested review from randall-Mysten

@sadhansood sadhansood Awaiting requested review from sadhansood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longbowlu @lxfind @patrickkuo