[validator] Drop tx from WAL when validator halt #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
force-pushed
the
validator-drop-wal-validator-halt
branch
from
950001b to
ca7d165
Compare
velvia
approved these changes
Oct 13, 2022
| .await | ||
| { | ||
| if matches!(err, SuiError::ValidatorHaltedAtEpochEnd) { | ||
| debug!( |
There was a problem hiding this comment.
Just curious, how many TXes are expected to fall into this condition, of not being able to proceed because of a halt? And is it necessary to halt right away, instead of letting them finish?
There was a problem hiding this comment.
We could wait a bit to reduce the chance of this happening, but at some point we need to close the door
mystenmark
approved these changes
Oct 13, 2022
lxfind
force-pushed
the
validator-drop-wal-validator-halt
branch
from
ca7d165 to
4b9f868
Compare
lxfind
force-pushed
the
validator-drop-wal-validator-halt
branch
from
4b9f868 to
61a206d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tx failed to commit due to validator halt, it will never succeed. We should drop it from WAL to prevent retrying.